[10432] Rename ASSERT -> MANGOS_ASSERT and related fixes

[newsbot]

автор: VladimirMangos

m src/framework/GameSystem/NGrid.h

m src/framework/GameSystem/TypeContainer.h

m src/framework/Utilities/LinkedReference/Reference.h

m src/game/AchievementMgr.cpp

m src/game/AuctionHouseMgr.cpp

m src/game/AuctionHouseMgr.h

m src/game/Bag.cpp

m src/game/Bag.h

m src/game/BattleGround.h

m src/game/BattleGroundAB.cpp

m src/game/BattleGroundAB.h

m src/game/BattleGroundAV.cpp

m src/game/BattleGroundAV.h

m src/game/Camera.cpp

m src/game/Camera.h

m src/game/CellImpl.h

m src/game/Chat.cpp

m src/game/Chat.h

m src/game/ConfusedMovementGenerator.cpp

m src/game/Corpse.cpp

m src/game/Corpse.h

m src/game/Creature.cpp

m src/game/CreatureAISelector.cpp

m src/game/DBCStores.cpp

m src/game/GameObject.cpp

m src/game/GossipDef.cpp

m src/game/InstanceSaveMgr.cpp

m src/game/InstanceSaveMgr.h

m src/game/Item.cpp

m src/game/Mail.cpp

m src/game/Map.cpp

m src/game/Map.h

m src/game/MapInstanced.cpp

m src/game/MapInstanced.h

m src/game/MapManager.cpp

m src/game/MapManager.h

m src/game/MotionMaster.cpp

m src/game/MovementGenerator.h

m src/game/Object.cpp

m src/game/Object.h

m src/game/ObjectAccessor.cpp

m src/game/ObjectAccessor.h

m src/game/ObjectGridLoader.cpp

m src/game/ObjectGridLoader.h

m src/game/ObjectMgr.cpp

m src/game/ObjectMgr.h

m src/game/Pet.cpp

m src/game/Pet.h

m src/game/Player.cpp

m src/game/Player.h

m src/game/PoolManager.cpp

m src/game/PoolManager.h

m src/game/Spell.cpp

m src/game/Spell.h

m src/game/SpellAuras.cpp

m src/game/SpellMgr.cpp

m src/game/SpellMgr.h

m src/game/ThreatManager.cpp

m src/game/Traveller.h

m src/game/Unit.cpp

m src/game/UpdateData.cpp

m src/game/UpdateMask.h

m src/game/Vehicle.h

m src/game/WaypointManager.cpp

m src/game/WaypointManager.h

m src/game/World.cpp

m src/realmd/AuthSocket.cpp

m src/shared/Auth/HMACSHA1.cpp

m src/shared/ByteBuffer.h

m src/shared/Common.h

m src/shared/Database/QueryResult.h

m src/shared/Database/QueryResultMysql.cpp

m src/shared/Errors.h

m src/shared/Threading.cpp

m src/shared/revision_nr.h

m src/shared/vmap/MapTree.cpp

m src/shared/vmap/VMapDefinitions.h

[10432] Rename ASSERT -> MANGOS_ASSERT and related fixes



ASSERT hard use in predictable way because diff. 3rd party libs code

redefine it inf different ways and hard make sure that used in end

of mangos define version. This is real detected problem make some

expected assert checks ignored and so bugs not detected as expected from code.



In addition made related changes:

* Common.h header expected to be first include in any src/game/header except most simple cases.

* Related FILE.h header expected to be first include in FILE.cpp

* Fixed some absent includes and type forwards for safe build without PCH enabled.

* Avoid using MANGOS_ASSERT in src/framework code

Дальше...