Smart PvP flag timers

[newsbot]

Автор: Warlockbugs

Smart PvP flag timers



Concentrating all PvP timers in one place.



Contested PvP flag propagation works in conjuction with PvP flag propagation.



New contested PvP flag API modeled after pre-existed PvP flag API.



Many outdated pieces of code related to contested are now cleaned up.



Most notable changes:

* PLAYER_FLAGS_IN_PVP renamed to more official term PLAYER_FLAGS_PVP_DESIRED to avoid confusion: based on lua GetPVPDesired()

* A better performance PvP flag timer (using diffs only).

* Improved contested PvP flag propagation logic (e.g. healing a victim who didn***39;t fight back will not flag healer).

* Getting attacked in PvP now refereshes victim***39;s PvP flag timer.

* Additionally update caster/attacker***39;s PvP flag on spell/attack landing in compliance with demons videos (in addition to current update on melee swing timer and pre-cast).

* A number of changes to PvP flag timer to improve world PvP encounter experience on PvE ruleset realms in some scenarios:

- PvP flag timer now freezes when player is in outdoor PvP capture points.

- PvP flag timer now freezes when player is a PvP objective flag carrier.

- Experimental: All PvP flag timers now freeze during actual PvP combat to prevent any premature flag drops.

* Initial implementation for a few wrapper extensions over SetInCombatWith to hold the new PvP flag timer logic in:

- SetInCombatWithAggressor

- SetInCombatWithAssisted

- SetInCombatWithVictim

* WotLK-specific feature: Full PLAYER_FLAGS_PVP_TIMER flag management.

Подробнее...