Combat Rolls Overhaul: Abilities, Spells, Crit, Weapon skill

[newsbot]

Автор: Warlockbugs

Combat Rolls Overhaul: Abilities, Spells, Crit, Weapon skill



* Unified crit chance for abilities and attacks

* Resolved ambiguity regarding aura SPELL_AURA_MOD_SPELL_CRIT_CHANCE_SCHOOL for abilities:

- Aura no longer applies to abilities (spells which use melee attack table).

- Paladin Talent Holy Power was used as a reference for this aura

* Some new API for spell calculations.

* Fixed NPC***39;s spell crit chance contribution by auras (mainly for pets).

* Implemented support for multi-school crit chance: the highest value among all fitting magic schools will be used.

* Magic Resistance: Implemented basic support for Chaos spell school ignoring magic resistances

- Presence of physical school as a multi-school component will now result in 0 resistance within calculation.

- Presence of physical school as a multi-school compoment will not add bonus mitigation to higher level targets.

* Re-utilize existing weapon type selector from SpellMgr in all ability calculations

* WotLK: Glyph of Fire Blast now correctly works on incapacitated targets

* Hotfixed weapon skill usage for abilities in general

* Spell Critical Chance changes:

- Unified Spell Crit chance storage across all cores and for both units and players

- Player***39;s UI display fields in TBC+ are no longer used for storage, only for character sheet display

- Some caching in spell crit auras handlers

- Optimized accessing unit***39;s spell crit querying (fixed storage instead of aura count each time)

* Complete reconstruction of obscure Physical Spell Critical Chance stat and it***39;s application cases:

- Physical spell crit chance is back in the game based on sniff and addons data

- Thunder Clap (in Classic/TBC), Healthstones and a few other spells now benefit from physical spell crit chance

- Classic/TBC: Rallying Cry of the Dragonslayer buff now affects physical spell crit chance

- Crusader weapon enchant self-heal proc is now able to crit at physical spell crit chance rate

- Warriors and Rogues in pre-WotLK environment have access to physical spell crit only through group-wide auras and specific items

- Warriors and Rogues in WotLK naturally have physical spell crit in any gear thanks to merged crit ratings

Подробнее...