[11886]58886 (Food - spell eater)

[rsa]

subj
https://github.com/mangosR2/mangos/c...b6fdc66c1d14d6

[schmoozerd]

Small Question:
Why not use GetTickCount() as check to trigger the (de)buff?

Also http://www.elsanglin.com/dalaran_fishing.html says:
"There is a better chance of gaining Well Fed than Wild Magic"

[rsa]

Сообщение от schmoozerd

Small Question:
Why not use GetTickCount() as check to trigger the (de)buff?

Also http://www.elsanglin.com/dalaran_fishing.html says:
"There is a better chance of gaining Well Fed than Wild Magic"

1. this one of possible methods. I never claim to ultimate truth is another option to set m_isPeriodic = false. I like this option because with it much more difficult to use exploit with shields (immunity).
2. i read much more messages about chance. 50% random buff, 50% morph.

[schmoozerd]

hm, I see.

Well, maybe can wait till laise gives some suggestion what should be taken as default style for such cases

[schmoozerd]

in 11886. Thank you.

Used the version with GetAuraTicks, as this is used in a few similar places;
so if we agree to change this style, we must change in many places

I think it should be ok as well, except we can somehow manage a test where we are immune on first tick, and get the buff on second tick.