Aura stacking rewrite: Stage 1 (Positive/Negative effects)

[newsbot]

Автор: Warlockbugs

Aura stacking rewrite: Stage 1 (Positive/Negative effects)



This is the first stage of the ongoing aura rewrite task.



The changelog:



Revamp of positive/negatve effects handling:

* Introducing neutral target modes category: positive/negative sign depends on caster***39;s and target***39;s relations.

* Existing target modes are now split into 3 categories: friendly, hostile, neutral.

* Positive/negative effect detection revamped and cleaned up to use the new target mode logic. A few bugs may appear due to neutral targets behaviour, report them asap for hotfix.

* Small improvement for aura cancel handler.



Changes to proc/trigger system:

* Additional target triggers now use target mode sign check to not proc hostile procs on friendly targets (SP***39;s Shadow Weaving).

* Spell proc now has a basic check for target mode relation between the target and the caster to not cast hostile procs on friendly targets, unless reflected (To be improved in the future).



Misc changes:

* Friendly Fire spells (such as Gruul***39;s Shatter) should no longer put friendly players in PvP combat with each other.



Changes to spell hit detection system:

* Failed hostile spell hits now put caster in combat with creatures.

* Failed hostile spell hits now put caster in PvP combat with players.

* Fixes Polymorph and several other spells not initiating combat: SPELL_ATTR_STOP_ATTACK_TARGET does not prevent aggro.

Подробнее...